Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GROW-2929): update lwgenerate to support GCP generation #1631

Merged
merged 1 commit into from
May 30, 2024

Conversation

leijin-lw
Copy link
Contributor

@leijin-lw leijin-lw commented May 30, 2024

Summary

How did you test this change?

Add unit tests

Issue

@leijin-lw leijin-lw requested a review from a team as a code owner May 30, 2024 20:24
@leijin-lw leijin-lw force-pushed the leijin-gcp-generate branch from 9adf26d to e5f093c Compare May 30, 2024 20:27
@leijin-lw leijin-lw changed the title feat(GROW-2929) Update lwgenerate to support GCP generation. feat(GROW-2929): update lwgenerate to support GCP generation May 30, 2024
@leijin-lw leijin-lw force-pushed the leijin-gcp-generate branch from e5f093c to 12f27e6 Compare May 30, 2024 20:35
@leijin-lw leijin-lw requested a review from ipcrm May 30, 2024 20:36
Copy link
Contributor

@ipcrm ipcrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! One question on GKE's GCP provider

lwgenerate/gcp/gcp.go Outdated Show resolved Hide resolved
lwgenerate/gcp/gke.go Outdated Show resolved Hide resolved
Signed-off-by: Lei Jin <lei.jin@lacework.net>
@leijin-lw leijin-lw force-pushed the leijin-gcp-generate branch from 12f27e6 to 16bf2d7 Compare May 30, 2024 20:51
@leijin-lw leijin-lw requested a review from ipcrm May 30, 2024 20:51
@leijin-lw leijin-lw merged commit 2c64710 into main May 30, 2024
13 checks passed
@leijin-lw leijin-lw deleted the leijin-gcp-generate branch May 30, 2024 21:16
@lacework-releng lacework-releng mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants