Skip to content

feat: refactor UX for lacework generate cloud-account azure #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lokesh-vadlamudi merged 6 commits into from
May 20, 2025
Merged

feat: refactor UX for lacework generate cloud-account azure #1710

lokesh-vadlamudi merged 6 commits into from
May 20, 2025

Conversation

@lokesh-vadlamudi
Copy link
Collaborator

@lokesh-vadlamudi lokesh-vadlamudi commented May 12, 2025 •
edited
Loading

Summary
Refactor the UX of lacework generate cloud-account azure

Related JIRA:
https://lacework.atlassian.net/browse/CAD-838

Screen shots:

Screenshot 2025-05-19 at 2 21 12 PM

Tests performed:

  1. Activity log integration successful.
  2. Azure configuration integration successful.

@lokesh-vadlamudi lokesh-vadlamudi self-assigned this May 12, 2025
@lokesh-vadlamudi lokesh-vadlamudi force-pushed the lvadlamudi-CAD-838 branch 2 times, most recently from ba27652 to 85c587d Compare May 15, 2025 18:08
@lokesh-vadlamudi lokesh-vadlamudi marked this pull request as ready for review May 15, 2025 20:00
@lokesh-vadlamudi lokesh-vadlamudi requested a review from a team as a code owner May 15, 2025 20:00
@lokesh-vadlamudi lokesh-vadlamudi requested review from goodmorninggoaway and lwmobeent and removed request for a team May 15, 2025 20:00
@PengyuanZhao
Copy link
Contributor

PengyuanZhao commented May 15, 2025 •
edited
Loading

Some feedback on the UI/UX:

  1. Wording:
    • Remove "Azure"
    • Remove "Specify"
    • Add colon if missing
    • Integration name first letter should be uppercase. E.g. "configuration" -> "Configuration"
  2. [Entra ID] -> [Entra ID Activity Log]
  3. [Active Directory] -> [Active Directory Application]
    • Create Active Directory Integration? -> Create Active Directory Application?
  4. Validate all region inputs
  5. Remove the unneeded "Configure advanced integration options?" section
  6. Remove [Common]
  7. Move the Azure Subscription ID question to the top
    • Remove "Set Azure Subscription ID?"

@lokesh-vadlamudi lokesh-vadlamudi force-pushed the lvadlamudi-CAD-838 branch 2 times, most recently from 193dba6 to 35cc1f0 Compare May 19, 2025 20:29
PengyuanZhao
PengyuanZhao approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@PengyuanZhao PengyuanZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lokesh-vadlamudi lokesh-vadlamudi merged commit 17062e5 into main May 20, 2025
30 of 39 checks passed
@lokesh-vadlamudi lokesh-vadlamudi deleted the lvadlamudi-CAD-838 branch May 20, 2025 18:02
@lacework-releng lacework-releng mentioned this pull request Jun 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PengyuanZhao PengyuanZhao PengyuanZhao approved these changes

@goodmorninggoaway goodmorninggoaway Awaiting requested review from goodmorninggoaway goodmorninggoaway was automatically assigned from lacework/eng-product-platform

@lwmobeent lwmobeent Awaiting requested review from lwmobeent lwmobeent was automatically assigned from lacework/eng-product-platform

Assignees

@lokesh-vadlamudi lokesh-vadlamudi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lokesh-vadlamudi @PengyuanZhao