feat(cli): --subaccount flag to manage sub-accounts #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
force-pushed
the
afiune/manage-tenants
branch
from
23592c3 to
74163f7
Compare
afiune
force-pushed
the
afiune/manage-tenants
branch
3 times, most recently
from
a311cbe to
f9b42fd
Compare
This change will allow users to manage sub-accounts (tenants) with a new flag named `--tenant` To list integrations from the organization account ``` $ lacework integrations list ``` To list integrations from a sub-account ``` $ lacework integrations list --tenant sub-account ``` Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
A user will be able to configure a persistent tenant with the command: ``` $ lacework configure --tenant sub-account ``` To remove the configured tenant use the `--remove_tenant` flag: ``` $ lacework configure --remove_tenant ``` Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune
force-pushed
the
afiune/manage-tenants
branch
from
f9b42fd to
c1f14b4
Compare
afiune
added a commit
to hashicorp/terraform-provider-lacework
that referenced
this pull request
Jul 31, 2020
This change is adding a new argument to our provider named `tenant`,
it is otional and allows Organization Admins to manage multiple
sub-accounts with a single API key. It can also be sourced from the
`LW_TENANT` environment variable, or via the configuration file if
`profile` is specified.
Example: having a single API key with Organization Admin priviledges
configured into the local Lacework CLI configuratio file at
`~/.lacework.toml`:
```toml
[default]
account = "primary-account"
api_key = "my-org-admin-key"
api_secret = "my-org-admin-secret"
```
You can configure the Lacework provider to point to multipel
sub-accounts using this new argument:
```hcl
provider "lacework" {
alias = "primary"
}
provider "lacework" {
alias = "subaccount1"
tenant = "subaccount1"
}
provider "lacework" {
alias = "subaccount2"
tenant = "subaccount2"
}
provider "lacework" {
alias = "subaccountN"
tenant = "subaccountN"
}
```
Depends on lacework/go-sdk#177
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune
added a commit
to hashicorp/terraform-provider-lacework
that referenced
this pull request
Jul 31, 2020
This change is adding a new argument to our provider named `tenant`,
it is otional and allows Organization Admins to manage multiple
sub-accounts with a single API key. It can also be sourced from the
`LW_TENANT` environment variable, or via the configuration file if
`profile` is specified.
Example: having a single API key with Organization Admin priviledges
configured into the local Lacework CLI configuratio file at
`~/.lacework.toml`:
```toml
[default]
account = "primary-account"
api_key = "my-org-admin-key"
api_secret = "my-org-admin-secret"
```
You can configure the Lacework provider to point to multipel
sub-accounts using this new argument:
```hcl
provider "lacework" {
alias = "primary"
}
provider "lacework" {
alias = "subaccount1"
tenant = "subaccount1"
}
provider "lacework" {
alias = "subaccount2"
tenant = "subaccount2"
}
provider "lacework" {
alias = "subaccountN"
tenant = "subaccountN"
}
```
Depends on lacework/go-sdk#177
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
|
We need to change this PR to match the terminology from our documentation, |
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune
changed the title
afiune
force-pushed
the
afiune/api/v2
branch
from
9e6abf9 to
f21b14d
Compare
|
Superseded by #431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow users to manage sub-accounts with a new flag named
--subaccount.To list integrations from the primary account
To list integrations from a sub-account
Additionally, it is possible to configure a persistent sub-account with the command:
To remove the configured sub-account use the
--remove_subaccountflag:Finally, this new flag comes with its environment variable
LW_SUBACCOUNTthat can beused to override settings coming from the Lacework configuration file.
Signed-off-by: Salim Afiune Maya afiune@lacework.net