feat: add github summary integration #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eriwyr
approved these changes
Jun 28, 2023
jycamier
changed the title
timarenz
approved these changes
Jun 28, 2023
|
hey, thank you so much for your contribution. can you please make sure you sign your commits as per our guidelines? much appreciated. |
jycamier
force-pushed
the
feat/gha-summary
branch
from
922eb0b to
cf174f6
Compare
|
Hi @timarenz |
|
Is there anything blocking this from being merged? |
|
Just merged and will release. Thank for the contribution. |
|
Okay, so we need to revert this change as we can not parse the exit code of the lw-scanner command anymore. Exit code is overwritten by the pipe to tee. |
|
Indeed. Sorry. I'll fix it in a few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #51
Summary
Github Summary is a simple way to expose the results of your pipeline to developers in a pull request context.
How did you test this change?
I've added a new pipeline which test it.
https://github.com/jycamier/lw-scanner-action/actions/runs/5392578473
Issue
#51