Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v1.0.0): Use native policies from the platform #9

Merged
merged 13 commits into from
Jun 22, 2022

Conversation

afiune
Copy link
Contributor

@afiune afiune commented Mar 17, 2022

Summary

This is a refactoring of the action to fully remove jq and super seed the “legacy” vulnerability testing with our policy feature.

For testing, an image is built locally within the test workflow. The action then picks up the locally cached image and therefore always tests the latest code.

How did you test this change?

Created new pipelines and updated existing ones.

Issue

https://lacework.atlassian.net/browse/ALLY-891

@guardrails
Copy link

guardrails bot commented Mar 17, 2022

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

afiune added 2 commits May 17, 2022 18:30
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
This fixes the error:
```
```

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
action.yaml Outdated
runs:
using: "docker"
image: "Dockerfile"
image: "docker://lacework/lw-scanner-action:latest"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image: "docker://lacework/lw-scanner-action:latest"
image: "Dockerfile"

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune force-pushed the action-refactor branch from 6aaaf91 to 6371062 Compare June 21, 2022 15:29
@afiune afiune requested review from ipcrm, timarenz and a team June 21, 2022 20:22
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune changed the title ALLY-891: Action refactor to use native policies refactor(v1.0.0): Use native policies from the platform Jun 21, 2022
Copy link
Collaborator

@timarenz timarenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@afiune afiune merged commit 3fc0763 into main Jun 22, 2022
@lacework-releng lacework-releng mentioned this pull request Jun 22, 2022
This was referenced Aug 5, 2022
@timarenz timarenz deleted the action-refactor branch January 19, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants