-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(v1.0.0): Use native policies from the platform #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
This fixes the error: ``` ``` Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune
commented
Jun 21, 2022
action.yaml
Outdated
runs: | ||
using: "docker" | ||
image: "Dockerfile" | ||
image: "docker://lacework/lw-scanner-action:latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
image: "docker://lacework/lw-scanner-action:latest" | |
image: "Dockerfile" |
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune
changed the title
ALLY-891: Action refactor to use native policies
refactor(v1.0.0): Use native policies from the platform
Jun 21, 2022
dmurray-lacework
approved these changes
Jun 22, 2022
timarenz
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a refactoring of the action to fully remove
jq
and super seed the “legacy” vulnerability testing with our policy feature.For testing, an image is built locally within the test workflow. The action then picks up the locally cached image and therefore always tests the latest code.
How did you test this change?
Created new pipelines and updated existing ones.
Issue
https://lacework.atlassian.net/browse/ALLY-891