feat: CloudTrail Object-level logging #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
make it so! (comment trigger for tests) |
|
@dmurray-lacework Any chance we could get some eyes on this for review? |
There was a problem hiding this comment.
We need to update the Readme docs with terraform-docs markdown
https://github.com/terraform-docs/terraform-docs/
We also require a new example in examples/ directory with the enable_cloudtrail_s3_management_events field being used.
The ci_tests.sh needs updated with the new example in the TEST_CASES block.
|
@TIYZAP Nicely done! 🎉 CI: make it so... |
dmurray-lacework
approved these changes
Apr 25, 2023
dmurray-lacework
changed the title
|
@dmurray-lacework @afiune What's the ETA on a new release being created in order for this addition to be utilized? |
Merged
|
@TIYZAP it has been released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the
terraform-aws-cloudtrailmodule does not contain support for Object-level logging, specifically the ability to add anevent_selectorin order to enable said logging.This need for this functionality originated from the following policies;
lacework-global-80 (Ensure that Object-level logging for write events is enabled for S3 buckets)
lacework-global-81 (Ensure that Object-level logging for read events is enabled for S3 buckets)
Added a dynamic block which can be enabled / disabled based on an associated variable.
Added a additional variable
How did you test this change?
Swapped the
sourceto my local path and ran aterraform initagainst one of our environments. Modules initialized cleanly.Issue
N/A