fix: org cloudtrail bucket policy #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darren Murray <darren.murray@lacework.net>
dmurray-lacework
force-pushed
the
dmurray-lacework/GROW-2549/org_trail_policy
branch
from
93fde14 to
1db59c5
Compare
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
PengyuanZhao
approved these changes
Nov 2, 2023
afiune
reviewed
Nov 2, 2023
| @@ -166,6 +166,9 @@ resource "aws_s3_bucket_versioning" "cloudtrail_bucket_versioning" { | |||
| } | |||
| } | |||
|
|
|||
| data "aws_organizations_organization" "organization" { | |||
There was a problem hiding this comment.
Can we validate that this "data source" add some new permission to our prefilght checklists?
dmurray-lacework
deleted the
dmurray-lacework/GROW-2549/org_trail_policy
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://docs.aws.amazon.com/awscloudtrail/latest/userguide/cloudtrail-create-and-update-an-organizational-trail-by-using-the-aws-cli.html
How did you test this change?
Issue
https://lacework.atlassian.net/browse/GROW-2549