chore(Makefile): directives for Go pkg dependencies #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
ghost
requested review from
ghost
self-assigned this
mjunglw
approved these changes
Mar 25, 2020
afiune
added a commit
that referenced
this pull request
Oct 7, 2020
When you run terraform apply after creating a gcp resource, we were trying to update the `private_key` when it is a sensitive element and the Lacework server, for security reasons, doesn't return that secret, which means that the resource was always different. We are adding a suppression to avoid updating the resource. Closes hashicorp/terraform-provider-lacework#4 Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
dmurray-lacework
pushed a commit
that referenced
this pull request
May 27, 2021
When you run terraform apply after creating a gcp resource, we were trying to update the `private_key` when it is a sensitive element and the Lacework server, for security reasons, doesn't return that secret, which means that the resource was always different. We are adding a suppression to avoid updating the resource. Closes hashicorp/terraform-provider-lacework#4 Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a couple of new Makefile directives:
make depsVendors all go dependencies, if
UPDATE_DEPenv variable is specified,it updates that single dependency.
Example: Update the Lacework go-sdk package
make alldepsSame as
depsbut for all dependencies.Signed-off-by: Salim Afiune Maya afiune@lacework.net