Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Migrate Cisco webex alert channel to API v2 #193

Merged

Conversation

vatasha
Copy link
Contributor

@vatasha vatasha commented Oct 10, 2021


name: Migrate Cisco Webex alert channel to API v2
about: fix: Migrate Cisco webex alert channel to API v2

Issue: https://lacework.atlassian.net/browse/ALLY-638?atlOrigin=eyJpIjoiZWQwNzA2NTc0OTc5NGEwMWIzNDYwMzNkYWNhZmQ4MTUiLCJwIjoiaiJ9

Description:
Migrate the cisco webex alert channel to use API v2

Additional Info:
#147

Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment below, could we please update the Schema and add Description to all the fields that don't have it? just like we were doing in the other pull requests. 💯

defer terraform.Destroy(t, terraformOptions)

// Create new Cisco webex Alert Channel
create := terraform.InitAndApply(t, terraformOptions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
create := terraform.InitAndApply(t, terraformOptions)
create := terraform.InitAndApplyAndIdempotent(t, terraformOptions)

@vatasha vatasha requested a review from afiune October 12, 2021 03:50
@afiune afiune merged commit 66e8251 into main Oct 12, 2021
@afiune afiune deleted the vatasha/ally-638/migrate-cisco-webex-alert-channel-api-v2 branch October 12, 2021 10:53
@lacework-releng lacework-releng mentioned this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants