test: fix s3 alert channel integration test #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
reviewed
Nov 9, 2021
Co-authored-by: Salim Afiune <afiune@lacework.net>
afiune
reviewed
Nov 9, 2021
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune
force-pushed
the
vatasha/ally-689/enable-s3-alert-chan-intg-test
branch
from
87e2145 to
0f9f793
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Fix S3 alert channel integration test
about: test: fix s3 alert channel integration test
Issue: https://lacework.atlassian.net/browse/ALLY-689?atlOrigin=eyJpIjoiOGZlMGIzODRiZDE5NDhmZWJhMWE2YzJhMzEyYzVkYzciLCJwIjoiaiJ9
Description:
Fix the integration test for S3 alert channels by using a valid bucket_arn, role_arn, and external_id. The s3 data export module was used to create these resources.
Additional Info:
Include any other relevant information such as how to use the new fuctionality, screenshots, etc.