refactor: encourage the use of anonymous queries #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation of this change it to avoid making our users set the query id twice, it makes no sense to allow them to configure a different query id, especially not since the platform enforces that both, the query id and the query text match. Furthermore, we have introduced the concept of anonymous queries, such queries are encouraged and should the default way that users create and manage LQL queries. This change updates all documentation and tests to avoid adding the query id inside the query text. Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune
commented
Mar 2, 2022
| @@ -176,4 +231,22 @@ var ( | |||
| EVENT | |||
| } | |||
| }` | |||
|
|
|||
| queryDeprecatedSyntaxWithID = `Lql_Terraform_Query { | |||
There was a problem hiding this comment.
I added one test to:
- show that this method has been deprecated and
- we still support it
dmurray-lacework
approved these changes
Mar 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
Description:
The motivation of this change it to avoid making our users set the query
id twice, it makes no sense to allow them to configure a different query
id, especially not since the platform enforces that both, the query id and
the query text match.
Furthermore, we have introduced the concept of anonymous queries, such
queries are encouraged and should the default way that users create and
manage LQL queries.
This change updates all documentation and tests to avoid adding the
query id inside the query text.
Signed-off-by: Salim Afiune Maya afiune@lacework.net
Additional Info:
Updated integration tests and documentation.