Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: time parse error for expiry field #332

Merged
merged 2 commits into from
Jun 23, 2022
Merged

fix: time parse error for expiry field #332

merged 2 commits into from
Jun 23, 2022

Conversation

dmurray-lacework
Copy link
Collaborator

@dmurray-lacework dmurray-lacework commented Jun 23, 2022 •
edited
Loading

Issue: https://lacework.atlassian.net/browse/ALLY-1055

Description:

  • Check for empty string before attempting to parse expiry
  • Add integration test with no expiry field

@dmurray-lacework
fix: time pasre error for expiry field
980a3f5 
Signed-off-by: Darren Murray <darren.murray@lacework.net>
@dmurray-lacework dmurray-lacework changed the title fix: time pasre error for expiry field fix: time parse error for expiry field Jun 23, 2022
@dmurray-lacework
test: no expiry test
471c589 
Signed-off-by: Darren Murray <darren.murray@lacework.net>
@dmurray-lacework dmurray-lacework requested a review from rmoles June 23, 2022 12:44
rmoles
rmoles approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM!

@rmoles rmoles merged commit 8c691ef into main Jun 23, 2022
@rmoles rmoles deleted the dmurray-lacework/ALLY-1055 branch June 23, 2022 12:47
@lacework-releng lacework-releng mentioned this pull request Jun 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoles rmoles rmoles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmurray-lacework @rmoles