refactor: migrate resource_lacework_integration_docker_hub to use v2 api #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
afiune
suggested changes
Sep 29, 2022
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
dmurray-lacework
added a commit
that referenced
this pull request
Nov 2, 2022
…api (#378) * refactor: migrate resource_lacework_integration_docker_hub to use v2 api
afiune
pushed a commit
that referenced
this pull request
Nov 8, 2022
…api (#378) * refactor: migrate resource_lacework_integration_docker_hub to use v2 api
Closed
This was referenced Nov 8, 2022
Merged
Closed
Closed
Merged
afiune
reviewed
Nov 23, 2022
| api.DockerhubData{ | ||
| LimitByTag: castAttributeToStringSlice(d, "limit_by_tags"), | ||
| LimitByRep: castAttributeToStringSlice(d, "limit_by_repositories"), | ||
| LimitByLabel: castAttributeToArrayKeyMapOfStrings(d, "limit_by_labels"), |
There was a problem hiding this comment.
Why did we use this function? 🤔
There was a problem hiding this comment.
The Schema for this field is:
"limitByLabel": {
"default": [],
"description": "When sending a request, if you do not want to assess all images in this registry, specify `key:value` pairs so that only images with matching label `key:value` pairs will be assessed. To change which images you want to assess, update this field so the change is captured during the next polling period. Supported field input: `key:value`. If you specify tag and label limits, they function as an AND. When included in a response, returns a list of labels that will be used to assess images.",
"items": {
"example": [
{
"key1": "value1"
},
{
"key2": "value2"
}
],
"type": "object"
},
"title": "Limit by Label(s) (optional)",
"type": "array"
},
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darren Murray darren.murray@lacework.net
Issue:
https://lacework.atlassian.net/browse/ALLY-1136
Description:
migrate resource_lacework_integration_docker_hub to use v2 api