Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade Go version to 1.15 #48

Merged
merged 4 commits into from
Dec 14, 2020
Merged

build: upgrade Go version to 1.15 #48

merged 4 commits into from
Dec 14, 2020

Conversation

dmurray-lacework
Copy link
Collaborator

Upgrade Go version to 1.15

@dmurray-lacework
build: upgrade Go version to 1.15
3338c49 
Signed-off-by: Darren Murray <darren.murray@lacework.net>
afiune
afiune suggested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update our pipeline to run on the same version, please update this line:

https://github.com/lacework/terraform-provider-lacework/blob/master/.circleci/config.yml#L18

@dmurray-lacework
build: upgrade Go version to 1.15 on pipeline
447bec6 
Signed-off-by: Darren Murray <darren.murray@lacework.net>
@dmurray-lacework
build(darwin/386): unsupported macOS arch
fc484d9 
Signed-off-by: Darren Murray <darren.murray@lacework.net>
afiune
afiune suggested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch about the macOS supported platform. We also need to remove this line:

https://github.com/lacework/terraform-provider-lacework/blob/master/scripts/release.sh#L21

@dmurray-lacework
build(darwin/386): unsupported macOS arch
65b57bf 
Signed-off-by: Darren Murray <darren.murray@lacework.net>
afiune
afiune approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-199587965

@afiune afiune merged commit 65cc622 into master Dec 14, 2020
@afiune afiune deleted the dmurray-lacework/go-1.15 branch December 14, 2020 19:26
@afiune afiune mentioned this pull request Dec 17, 2020
Merged
dmurray-lacework added a commit that referenced this pull request May 27, 2021
@dmurray-lacework
build: upgrade Go version to 1.15 (#48)
4f7c058 
This change is removing support for macOS 32-bits binaries.

Signed-off-by: Darren Murray <darren.murray@lacework.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afiune afiune afiune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmurray-lacework @afiune