fix: deprecate alert_rule event_categories attribute #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
afiune
suggested changes
Aug 29, 2023
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
dmurray-lacework
deleted the
dmurray-lacework/GROW-2333/deprecate-event-categories
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://lacework.atlassian.net/browse/GROW-2333
Description:
The alert_rule field
event_categorieshas been renamed to alert_subcategories in the Alert Rule UI.This change marks
event_categoriesas deprecated in favour ofalert_subcategoriesto maintain parity with the Lacework UI.resource_lacework_alert_rulehas been updated to include the fieldalert_subcategoriesand setevent_categoriesto deprecatedintegration/resource_lacework_alert_rule_test.gohas been updated to usealert_subcategoriesTesting
integration/resource_lacework_alert_rule_test.gointegration test has been updated with the new field.