Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resource_id and empty id in agentless GCP #599

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix: resource_id and empty id in agentless GCP #599

merged 1 commit into from
Dec 7, 2023

Conversation

badass-aoz
Copy link
Contributor

@badass-aoz badass-aoz commented Dec 6, 2023 •
edited
Loading

Issue:
Those were noticed while I was referring to GCP lacework provider for Azure.

  1. resource_id should be the id, not integration id. resource_id should be either a project id or an org id, whereas the intgGuid is the common integration id
  2. the setID("") was not needed

Test w/ the integration test.

@badass-aoz badass-aoz requested a review from a team as a code owner December 6, 2023 23:50
@badass-aoz badass-aoz merged commit 3dadc38 into main Dec 7, 2023
2 checks passed
@badass-aoz badass-aoz deleted the gcp_agentless branch December 7, 2023 00:34
@lacework-releng lacework-releng mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammarekbote ammarekbote ammarekbote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badass-aoz @ammarekbote