feat: retry mechanism for all cloud resources #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune
changed the title
afiune
commented
Mar 4, 2021
| @@ -29,6 +29,7 @@ The following arguments are supported: | |||
| * `name` - (Required) The AWS Config integration name. | |||
| * `credentials` - (Required) The credentials needed by the integration. See [Credentials](#credentials) below for details. | |||
| * `enabled` - (Optional) The state of the external integration. Defaults to `true`. | |||
| * `retries` - (Optional) The number of attempts to create the external integration. Defaults to `5`. | |||
There was a problem hiding this comment.
@scottford-lw @dmurray-lacework is this a good text for the new argument?
dmurray-lacework
approved these changes
Mar 4, 2021
afiune
commented
Mar 5, 2021
| @@ -34,6 +35,11 @@ func resourceLaceworkIntegrationAwsCfg() *schema.Resource { | |||
| Optional: true, | |||
| Default: true, | |||
| }, | |||
| "retries": { | |||
There was a problem hiding this comment.
@scottford-lw @dmurray-lacework Should this be max_retries instead? 🤔
There was a problem hiding this comment.
Yes, i think that better describes this parameters function.
There was a problem hiding this comment.
max_retries seems to be more the common nomenclature. At least from a quick search.
https://registry.terraform.io/providers/hashicorp/aws/latest/docs#max_retries
Not a sticking point for me and happy for this to go with either. But I do prefer max_retries
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Merged
dmurray-lacework
pushed a commit
that referenced
this pull request
May 27, 2021
* feat: retry mechanism for all cloud resources Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Story
As a Lacework & Terraform user,
I need to have stable and predictable executions,
So that I don't break my production deployments.
Description
Users that have integrated our Terraform templates and providers into their CI/CD process are experiencing a number of API issues that are breaking their deployment processes/pipelines. We think that, when we introduce APIv2 into our Terraform provider, we will fix these issues but we cannot wait until this work is done in a couple of sprints, we need to have a solution sooner rather than later.
Proposal Solution
We will implement a retry mechanism that will default to 5 tries with incremental intervals in between. This parameter will be configurable so that if a user wants to try 10 times or more, they can configure it.
Acceptance Criteria
All cloud account resources should have implement this new retry mechanism, the resources we will implement it to are: