[mds-geography][mds-geography-author] Moving read-only geo points out of geo author, leaving metadata endpo… #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avatarneil
approved these changes
May 15, 2020
| if (err instanceof NotFoundError) { | ||
| return res.status(404).send({ error: err }) | ||
| } catch (error) { | ||
| logger.error('failed to read geography', error.stack) |
There was a problem hiding this comment.
Can get rid of this logging line, we only care about logging the error in the case of a ServerError (which is handled by the global middleware now).
marie-x
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ints.
PR Checklist
[mds-db] Add PG env var,[config] Fix eslint configImpacts
These are breaking changes, but it doesn't make much sense to duplicate code between the two services. The specs (still in PR) have both been updated to reflect the new distribution of endpoints between the two services.