[mds-api-server] [ALL VERSIONED APIS] Feature/neil/add versioning options #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdurling
approved these changes
May 18, 2020
…na-tech/mds-core into feature/neil/add-versioning-options
janedotx
reviewed
May 18, 2020
| * If the client did not negotiate a valid version, fall-through to a 406 response. | ||
| */ | ||
| if (supported.length > 0) { | ||
| const [{ latest }] = supported.sort((a, b) => b.q - a.q) |
There was a problem hiding this comment.
Nit but it seems to me that you could factor this out of the two branches of this if statement.
There was a problem hiding this comment.
Yeah I was thinking about that too, there's not a super clean way to structure this logic IMO. On one hand, being concise is ideal (though you can't be very concise here), on the other hand, being expressive is ideal. I'm gonna think on this a bit before merging and see if I can find a really clean way of writing it.
janedotx
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the API Versioning middleware to support
OPTIONSrequests for version negotiation as per https://github.com/openmobilityfoundation/mobility-data-specification/blob/master/general-information.mdPR Checklist
[mds-db] Add PG env var,[config] Fix eslint configImpacts