🐛[mds-stream] Change ts-nats import to properly resolve methods #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avatarneil
requested review from
mdurling,
janedotx,
marie-x,
macsj200 and
twelch
twelch
approved these changes
May 19, 2020
janedotx
approved these changes
May 19, 2020
mdurling
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Purpose
Though typescript/webpack do not complain, it appears that if you use a default-style import for ts-nats at runtime the methods are unable to be resolved. Tests are lacking for everything in mds-stream, and we ought to improve that at some point soon. This has been tested in one of our development environments and resolves the issue. I will probably cut a PR to update the typing for the ts-nats library at some point, too.
📦 Impacts:
mds-stream
mds-agency
mds-web-sockets
✅ PR Checklist