Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide custom locale detection option #26

Closed
nemphys opened this issue Feb 20, 2021 · 3 comments
Closed

Provide custom locale detection option #26

nemphys opened this issue Feb 20, 2021 · 3 comments

Comments

@nemphys
Copy link
Contributor

nemphys commented Feb 20, 2021 •
edited
Loading

It would be nice to have the ability to provide a custom function config option for locale detection (which would be executed first, before the hard-coded url/cookie/Accept-Language/lastLocale checks).
I am trying to store the locale in the session (not a separate cookie) and there is currently no way to do that.

EDIT: I can provide a PR if you are interested
@niftylettuce
Copy link
Contributor

Yes, PR welcome!

nemphys added a commit to nemphys/i18n that referenced this issue Feb 22, 2021
@nemphys
feat: custom locale detection using the new detectLocale parameter, c…
60fdd90 
…loses issue ladjs#26
nemphys added a commit to nemphys/i18n that referenced this issue Feb 26, 2021
@nemphys
feat: custom locale detection using the new detectLocale parameter, c…
1768f3f 
…loses issue ladjs#26
nemphys added a commit to nemphys/i18n that referenced this issue Feb 26, 2021
@nemphys
feat: custom locale detection using the new detectLocale parameter, c…
c105b1d 
…loses issue ladjs#26
nemphys added a commit to nemphys/i18n that referenced this issue Feb 26, 2021
@nemphys
feat: custom locale detection using the new detectLocale parameter, c…
24004ee 
…loses issue ladjs#26
@niftylettuce
Copy link
Contributor

Curious @nemphys are you using @ladjs too?

@niftylettuce
Copy link
Contributor

v7.1.0 released https://github.com/ladjs/i18n/releases/tag/v7.1.0 @nemphys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niftylettuce @nemphys