Merge pull request #1757 from ShiraNagen/cookies-domains

Send cookies to allowed domains
ladjs · Jan 18, 2023 · 93835cb · 93835cb
2 parents 759acfc + e98489a
commit 93835cb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/node/agent.js b/src/node/agent.js
@@ -65,7 +65,10 @@ Agent.prototype = Object.create(AgentBase.prototype);
 
 Agent.prototype._saveCookies = function (res) {
   const cookies = res.headers['set-cookie'];
-  if (cookies) this.jar.setCookies(cookies);
+  if (cookies) {
+    const url = parse(res.request?.url || '')
+    this.jar.setCookies(cookies, url.hostname, url.pathname);
+  }
 };
 
 /**

diff --git a/test/node/agency.js b/test/node/agency.js
@@ -120,6 +120,16 @@ describe('request', () => {
           assert.strictEqual(res.text, 'jar');
         }));
 
+    it('should not share cookies between domains', () => {
+      assert.equal(agent4.get('https://google.com').cookies, "");
+    });
+
+    it('should send cookies to allowed domain with a different path', () => {
+      const postRequest = agent4.post(`${base}/x/y/z`)
+      const cookiesNames = postRequest.cookies.split(';').map(cookie => cookie.split('=')[0])
+      cookiesNames.should.eql(['cookie', ' connect.sid']);
+    });
+
     it('should not share cookies', (done) => {
       agent2.get(`${base}/dashboard`).end((error, res) => {
         should.exist(error);