Make it possible to send in own encoder function as part of options object #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftylettuce
requested changes
Jan 18, 2022
|
see #1720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library does not support sending in your own encoder function as argument to
.auth()(encoderis hard coded there).This PR makes it an optional option.
Without this PR one needs to use the internal
._auth()method, which is bad practise..auth(): https://github.com/visionmedia/superagent/blob/master/src/client.js._auth(): https://github.com/visionmedia/superagent/blob/1277a880c32191e300b229e352e0633e421046c8/src/request-base.js#L514