Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update formidable to 2.0.1 #1651

Merged
merged 1 commit into from
Nov 30, 2021
Merged

build: update formidable to 2.0.1 #1651

merged 1 commit into from
Nov 30, 2021

Conversation

wopian
Copy link
Contributor

@wopian wopian commented Nov 25, 2021

The Make file doesn't run tests correctly for me (with fresh clone with yarn install && yarn test or after changes with yarn install && yarn test) so unable to test locally - almost all of the tests fail with "Error: Forbidden" when I checkout the master branch

Edit: CI tests via Travis aren't running either as Travis shut down travis-ci.org back in June this year, so the project needs to move to travis-ci.com with limited open source credits (though they have dubious security practises of late) or switch to GitHub Actions.

Closes #1650 #1609

@wopian wopian changed the title build: update formidable to 2.0.1 build: update formidable to 3.1.1 Nov 25, 2021
@wopian wopian changed the title build: update formidable to 3.1.1 build: update formidable to 2.0.1 Nov 25, 2021
@wopian wopian marked this pull request as ready for review November 25, 2021 15:15
@purejgleason
Copy link

Can we get a move on this?

@purejgleason
Copy link

Also why not just go all the way to 3?

@wopian
Copy link
Contributor Author

wopian commented Nov 30, 2021

Also why not just go all the way to 3?

2.x is the @latest tag on NPM.

3.x is re-written as an ES Module (not a dual ESM/CJS package), a breaking change for superagent users in an environment that does not support, or can't parse, ESM.

@purejgleason
Copy link

Also why not just go all the way to 3?

2.x is the @latest tag on NPM.

3.x is re-written as an ES Module (not a dual ESM/CJS package), a breaking change for superagent users in an environment that does not support, or can't parse, ESM.

If you will entertain 1 more question what is the reason supertest can't go full ESM stack? What still relies on CommonJS

@niftylettuce niftylettuce merged commit 6ac6429 into ladjs:master Nov 30, 2021
@niftylettuce
Copy link
Collaborator

I don't support ESM (nor TypeScript) right now

@niftylettuce
Copy link
Collaborator

Tests seem to be broken right now, possible due to this PR or 3c9c0f7 (related to #1267).

If someone can fix and submit a PR, then I can publish a new release of this package to npm.

You can reproduce by cloning this repo, running yarn, and then yarn test or just make test works.

@jimmywarting
Copy link
Contributor

jimmywarting commented Jan 2, 2022

I don't support ESM (nor TypeScript) right now

fyi, esm packages can be lazy imported from cjs using import('formidable').then(...)

lowest nodejs support for dynamic import is v12.17
(12.20 cuz formidable includes node: prefixes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formidable@1 is deprecated
4 participants