fix: fixed the errors of eslint #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/client/request.js
Outdated
| @@ -55,7 +55,7 @@ describe('request', function () { | |||
|
|
|||
| try { | |||
| var file = new File([''], 'image.jpg', { type: 'image/jpeg' }); | |||
| // eslint-disable-next-line unicorn/prefer-optional-catch-binding | |||
| ////eslint-disable-next-line unicorn/prefer-optional-catch-binding | |||
There was a problem hiding this comment.
Just remove this line altogether?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superagent has three eslint configuration files. The
.lib.eslintrcto valid the files under the directory of lib , the.dist.eslintrcto valid the files under the direcotry of dist, the property ofxoofpackage.jsonto valid all the project's file.For the issue of xojs/xo#598 from xo ,we can not disable the rule for low version node check, such as the rule
node/no-unsupported-features/node-builtins. So I just switch to use the native eslint, and add a new configuration file, named.eslintrc. This will also benefit for the vscode, when use the file.eslintrc, vscode can use the rules from it.For current project not install the eslint plugin of
eslint-plugin-unicorninpackage.json. So I have not set it as an extendtion to.eslintrc. Someone can install it manual and use the rules from it after the pull request is merged.