fix: do not force-set req.destroyed = true
on abort
#1774
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
this.req.destroyed = true
hack that was added in 8b1923d actually breaks the behavior of 14.0.0.Looking at
v14.0.0
's HTTP client's code, theabort
method internally callsdestroy
.destroy
has an early termination whendestroyed
is alreadytrue
. Settingdestroyed = true
before callingabort()
stops Node.js from internally closing the socket, potentially leading to memory leaks.It also breaks the behavior of
abort()
since Node.js deprecated it in favor ofdestroy()
(as Node.js internally relies ondestroy()
logic to terminate the call.Checklist