Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace should with node:assert #1782

Merged
merged 1 commit into from
Aug 30, 2023
+44 −40
Merged

test: replace should with node:assert #1782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/node/basic-auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'use strict';
const assert = require('assert');
const URL = require('url');
const request = require('../support/client');
const getSetup = require('../support/setup');
Expand All @@ -19,7 +19,7 @@ describe('Basic auth', () => {
new_url.pathname = '/basic-auth';

request.get(URL.format(new_url)).end((error, res) => {
res.status.should.equal(200);
assert.equal(res.status, 200);
done();
});
});
Expand All @@ -31,7 +31,7 @@ describe('Basic auth', () => {
.get(`${base}/basic-auth`)
.auth('tobi', 'learnboost')
.end((error, res) => {
res.status.should.equal(200);
assert.equal(res.status, 200);
done();
});
});
Expand All @@ -43,7 +43,7 @@ describe('Basic auth', () => {
.get(`${base}/basic-auth/again`)
.auth('tobi')
.end((error, res) => {
res.status.should.eql(200);
assert.equal(res.status, 200);
done();
});
});
Expand Down
76 changes: 40 additions & 36 deletions test/node/basic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('[node] request', () => {
describe('with an object', () => {
it('should format the url', () =>
request.get(url.parse(`${base}/login`)).then((res) => {
assert(res.ok);
assert.ok(res.ok);
}));
});

Expand Down Expand Up @@ -59,12 +59,13 @@ describe('[node] request', () => {
describe('res.links', () => {
it('should default to an empty object', () =>
request.get(`${base}/login`).then((res) => {
res.links.should.eql({});
assert.deepEqual(res.links, {});
}));

it('should parse the Link header field', (done) => {
request.get(`${base}/links`).end((error, res) => {
res.links.next.should.equal(
assert.equal(
res.links.next,
'https://api.github.com/repos/visionmedia/mocha/issues?page=2'
);
done();
Expand All @@ -78,24 +79,24 @@ describe('[node] request', () => {
.post(`${base}/echo`)
.unset('User-Agent')
.end((error, res) => {
assert.equal(void 0, res.header['user-agent']);
assert.equal(res.header['user-agent'], undefined);
done();
});
});
});

describe('case-insensitive', () => {
it('should set/get header fields case-insensitively', () => {
const r = request.post(`${base}/echo`);
r.set('MiXeD', 'helloes');
assert.strictEqual(r.get('mixed'), 'helloes');
const req = request.post(`${base}/echo`);
req.set('MiXeD', 'helloes');
assert.strictEqual(req.get('mixed'), 'helloes');
});

it('should unset header fields case-insensitively', () => {
const r = request.post(`${base}/echo`);
r.set('MiXeD', 'helloes');
r.unset('MIXED');
assert.strictEqual(r.get('mixed'), undefined);
const req = request.post(`${base}/echo`);
req.set('MiXeD', 'helloes');
req.unset('MIXED');
assert.strictEqual(req.get('mixed'), undefined);
});
});

Expand All @@ -106,7 +107,7 @@ describe('[node] request', () => {
assert.equal('boolean', typeof request_.write('{"name"'));
assert.equal('boolean', typeof request_.write(':"tobi"}'));
request_.end((error, res) => {
res.text.should.equal('{"name":"tobi"}');
assert.equal(res.text, '{"name":"tobi"}');
done();
});
});
Expand All @@ -116,19 +117,21 @@ describe('[node] request', () => {
it('should pipe the response to the given stream', (done) => {
const stream = new EventEmitter();

stream.buf = '';
let buf = '';
stream.writable = true;

stream.write = function (chunk) {
this.buf += chunk;
buf += chunk;
};

stream.end = function () {
this.buf.should.equal('{"name":"tobi"}');
assert.equal(buf, '{"name":"tobi"}');
done();
};

request.post(`${base}/echo`).send('{"name":"tobi"}').pipe(stream);
request.post(`${base}/echo`)
.send('{"name":"tobi"}')
.pipe(stream);
});
});

Expand All @@ -140,7 +143,7 @@ describe('[node] request', () => {
.end((error, res) => {
assert.ifError(error);
assert.equal('custom stuff', res.text);
assert(res.buffered);
assert.ok(res.buffered);
done();
});
});
Expand All @@ -158,7 +161,7 @@ describe('[node] request', () => {
assert.ifError(error);
assert.equal(res.type, type);
assert.equal(send, res.text);
assert(res.buffered);
assert.ok(res.buffered);
done();
});
});
Expand All @@ -174,18 +177,19 @@ describe('[node] request', () => {
.end((error, res) => {
assert.ifError(error);
assert.equal(null, res.text);
res.body.should.eql({});
let buf = '';
assert.deepEqual(res.body, {});
let str = '';
res.setEncoding('utf8');
res.on('data', (chunk) => {
buf += chunk;
str += chunk;
});
res.on('end', () => {
buf.should.equal('hello this is dog');
assert.equal(str, 'hello this is dog');
done();
});
});
});

it("should take precedence over request.buffer['someMimeType'] = true", (done) => {
const type = 'application/foobar';
const send = 'hello this is a dog';
Expand All @@ -200,15 +204,15 @@ describe('[node] request', () => {
assert.ifError(error);
assert.equal(null, res.text);
assert.equal(res.type, type);
assert(!res.buffered);
res.body.should.eql({});
let buf = '';
assert.equal(res.buffered, false);
assert.deepEqual(res.body, {});
let str = '';
res.setEncoding('utf8');
res.on('data', (chunk) => {
buf += chunk;
str += chunk;
});
res.on('end', () => {
buf.should.equal(send);
assert.equal(str, send);
done();
});
});
Expand All @@ -229,8 +233,8 @@ describe('[node] request', () => {

describe('.agent()', () => {
it('should return the defaut agent', (done) => {
const request_ = request.post(`${base}/echo`);
request_.agent().should.equal(false);
const agent = request.post(`${base}/echo`).agent();
assert.equal(agent, false);
done();
});
});
Expand All @@ -239,7 +243,7 @@ describe('[node] request', () => {
it('should set an agent to undefined and ensure it is chainable', (done) => {
const request_ = request.get(`${base}/echo`);
const returnValue = request_.agent(undefined);
returnValue.should.equal(request_);
assert.equal(returnValue, request_);
assert.strictEqual(request_.agent(), undefined);
done();
});
Expand All @@ -251,8 +255,8 @@ describe('[node] request', () => {
const request_ = request.get(`${base}/echo`);
const agent = new http.Agent();
const returnValue = request_.agent(agent);
returnValue.should.equal(request_);
request_.agent().should.equal(agent);
assert.equal(returnValue, request_);
assert.equal(request_.agent(), agent);
done();
});
});
Expand All @@ -264,9 +268,9 @@ describe('[node] request', () => {
.type('application/x-dog')
.send('hello this is dog')
.then((res) => {
assert.equal(null, res.text);
assert.equal(res.text, null);
assert.equal(res.body.toString(), 'hello this is dog');
res.buffered.should.be.true;
assert.equal(res.buffered, true);
});
});
});
Expand All @@ -283,7 +287,7 @@ describe('[node] request', () => {
.buffer(false)
.end((error, res) => {
assert.ifError(error);
assert(!res.buffered);
assert.equal(res.buffered, false);
assert.equal(res.header['content-length'], Buffer.byteLength(img));
done();
});
Expand Down Expand Up @@ -313,7 +317,7 @@ describe('[node] request', () => {
.send('wahoo')
.end((error, res) => {
try {
assert.equal('wahoo', res.text);
assert.equal(res.text, 'wahoo');
next();
} catch (err) {
next(err);
Expand Down