Skip to content

Commit

Permalink
5.0.0-0
Browse files Browse the repository at this point in the history
  • Loading branch information
@rimiti
rimiti committed Oct 2, 2019
1 parent ed9d49f commit 910a111
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "supertest",
"version": "4.0.2",
"version": "5.0.0-0",
"description": "SuperAgent driven library for testing HTTP servers",
"main": "index.js",
"author": "TJ Holowaychuk",
Expand Down

5 comments on commit 910a111

@DanielRamosAcosta
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rimiti I have a question, why was supertest bumped a major version? Does it have breaking changes? I can't find them in the release changelog/commit history.

@julienw
Copy link
Contributor

@julienw julienw commented on 910a111 Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that it's because they dropped support for older node versions.

(but I also got a new error in my code, not sure why yet...)

@julienw
Copy link
Contributor

@julienw julienw commented on 910a111 Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: the new error I had is with an on-purpose-invalid accept value which now returns 500 instead of 406 like my code does. My guess is that because of some dependency updates (not sure if that's express' updating of the accepts dependency, or nock) the server checks the syntax of the value before handing it over to my code. This also supports the idea of bumping the major version.

On a side note, this makes me slightly worried that I'm not testing my code in the same condition as the real thing 😅. Limitations of testing, I guess...

@julienw
Copy link
Contributor

@julienw julienw commented on 910a111 Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also superagent was bumped from v3 to v6. Given supertest inherits a lot from superagent this is another reason :-)

@DanielRamosAcosta
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks you!

Please sign in to comment.