On ECONNRESET, assert() calls undefined res.status which throws an error

[kadishmal]

When for some reason the remote server fails and the connection is reset, supertest cannot handle the error properly which is why the following error is thrown:

|"TypeError: Cannot read property 'status' of undefined",
|"    at Test.assert (/webapp/node_modules/supertest/lib/test.js:203:12)",
|"    at assert (/webapp/node_modules/supertest/lib/test.js:132:12)",
|"    at /webapp/node_modules/supertest/lib/test.js:129:5",
|"    at Test.Request.callback (/webapp/node_modules/superagent/lib/node/index.js:781:12)",
|"    at ClientRequest.<anonymous> (/webapp/node_modules/superagent/lib/node/index.js:736:10)",
|"    at ClientRequest.emit (events.js:95:17)",
|"    at Socket.socketOnEnd [as onend] (http.js:1569:9)",
|"    at Socket.g (events.js:180:16)",
|"    at Socket.emit (events.js:117:20)",
|"    at _stream_readable.js:944:16",
|"    at process._tickCallback (node.js:448:13)"

There is this code on line 202 in supertest/lib/test.js:

if (status) {
  if (res.status !== status) {
    var a = http.STATUS_CODES[status];
    var b = http.STATUS_CODES[res.status];
    return fn(new Error('expected ' + status + ' "' + a + '", got ' + res.status + ' "' + b + '"'), res);
  }

  // remove expected superagent error
  if (resError && resError instanceof Error && resError.status === status) {
    resError = null;
  }
}

On the line 203, which says if (res.status !== status) {, res is undefined. Because resError = { [Error: socket hang up] code: 'ECONNRESET', response: undefined }.

[RomanSchmidtAppinio]

Same here. During a stress test mongoose connection limit is reached and node is sending an empty result. So i get same exception.

My temporary Solution:

Test.prototype.assert = function(resError, res, fn){
if(!res) {
res = {
status: 'FOOO'
};
}

[mikelax]

This is a duplicate of #237. There is PR #258 to address this.

[kadishmal]

#260 doesn't fix this issue. In fact #260 doesn't include any code change except in the test case. Need to reopen.

[mleanos]

I'm having this issue as well on Windows 7. I've described my experiences with this issue here #230

[varunj90]

@kadishmal , @mleanos - any resolution to this?

#298

if you could help me with 298 . thanks !

[kadishmal]

No, this particular issue is still present. res.status is not handled properly because res is undefined.

[varunj90]

@kadishmal - thanks for the update. Do you know ETA for this fix; or know if supertest is working towards a fix?

My issue is similar to this : #298

[varunj90]

@mikelax - Do you know ETA for this fix; or know if supertest is working towards a fix?

My issue is similar to this : #298

[aides]

It's quite an old thread and it is closed, but I still encounter this issue. It is reproduced on Windows only and when I send a PUT with binary content with content-type set to a different value.
After googling this is still the most relevant place, so maybe someone knows how to address this problem?