Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that .end(..) closes the server #369

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Clarify that .end(..) closes the server #369

wants to merge 3 commits into from

Conversation

osher
Copy link

@osher osher commented Aug 30, 2016

No description provided.

@mikelax mikelax added this to the 2.1.0 milestone Sep 21, 2016
@mikelax mikelax removed this from the 2.1.0 milestone Oct 19, 2016
@osher
Copy link
Author

osher commented Dec 6, 2016

I'm doing a cleanup of my repositories, anybody here to accept this change? it's just Readme...

Readme.md Outdated
@@ -210,6 +214,8 @@ describe('request.agent(app)', function(){
### .end(fn)

Perform the request and invoke `fn(err, res)`.
If the call was created with an instance of a server - it **closes** the server, wether it was bound to a port or not.
Also mind that the `this` context inside teh callback is set to the `supertest.Test` instance, and not the mocha test or any other context you're running in.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teh

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo, inside teh callback should be inside the callback

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG. you're right. fixing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well... till the next cleanup ... I guess... 😛

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯_(ツ)_/¯ it happens. Thanks for fixing it!

@rimiti
Copy link
Contributor

rimiti commented Mar 8, 2019

@osher Can you please resolve conflicts ? 🙏

@rimiti rimiti added the conflicts Conflicts to resolve label Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Conflicts to resolve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants