Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert var to const / let #748

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Conversation

jimmywarting
Copy link
Contributor

...and use obj destruct

@niftylettuce niftylettuce merged commit 1d70492 into ladjs:master Jan 4, 2022
@jimmywarting jimmywarting deleted the var branch January 4, 2022 21:01
@niftylettuce
Copy link
Collaborator

@jimmywarting if you plan on making a large PR and don't want me to merge so quick just let me know

I also know that @shadowgate15 is working on fixing the tests!

@jimmywarting
Copy link
Contributor Author

jimmywarting commented Jan 4, 2022

Sometimes I prefer smaller PR, they are easier to review and gets merged/accepted faster.

also easier to avoid misstake you might not like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants