Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small misc quality of dev fixes too small for one PR
not sure if you didn't want any of this small fixes.
can easier be addressed if you just review and say what you didn't like about this PR so i can fix them.
all so it matches the similarity of how esm are built & required to be (for easier transition to esm if that day ever comes)
any chain use of
require('xyz').whatever...
only makes it harder to refactor to esm at some point later, and esm require explicit path so...superagent.Response
to not mix up with fetch response class...self = this
with arrow fnAlso wanted to convert TestAgent into a class, but you allow it to be called without
new
so changing it would be a breaking change... (unless you do something like this)also thought about using some private class fields but don't know how far you are willing to go with modernization