Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pick ephemeral port once per agent #846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ikonst
Copy link

@ikonst ikonst commented Nov 9, 2024

Fixes spurious low level errors in the form of "socket hang up" when rapidly testing.

By creating a listening server just once per agent, we can allow callers to strategize by reusing the agent and avoiding (a) the setup overheard, and (b) spurious failure due to the ephemeral port being random on every agent construction (previously, on every request).

Fixes #844.

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@ikonst ikonst changed the title fix: pick ephemeral just port fix: pick ephemeral port once per agent Nov 9, 2024
@ikonst ikonst force-pushed the fix-ephemeral-port branch from 8ae2a31 to 655f6f1 Compare November 9, 2024 23:29
@ikonst ikonst force-pushed the fix-ephemeral-port branch from 655f6f1 to e522f2c Compare November 9, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] supertest fails with intermittent "socket hang up" in loops
1 participant