fix(deploy): use javascript semantic-release package for deployment #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineDao
force-pushed
the
semantic-release
branch
from
5722049
to
1a6da34
Compare
Using the "pure" javascript implementation of semantic-release makes it a bit more flexible to set up custom scripts to run at different stages of the semantic release process. The packages used as well as scripts to run at different stages are specified in the .releaserc.json file. In this case we use standard semantic-release and add a custom deploy script on top of the normal github release setup. The custom deploy script is the new 'deploy.sh' file which takes the new version number as an argument to deploy the package to PyPi and build the documentation. ladybug-tools#125 build(pytest): add pytest-cov deps to dev-requirements.txt build(euclid): add euclid to dev-requirements.txt
AntoineDao
force-pushed
the
semantic-release
branch
from
1a6da34
to
0dd4649
Compare
|
Finally made it after so many force pushes to get dev-requirements.txt to play ball! |
mostaphaRoudsari
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Hi @AntoineDao, Thank you for getting this to work. I couldn't see from the code how you pass the version is the new workflow but I think I will know when I see it. Let's merge this in and see how it will work when merged to master.
mostaphaRoudsari
added
enhancement
|
🎉 This PR is included in version 0.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the "pure" javascript implementation of semantic-release makes it a bit more flexible to set
up custom scripts to run at different stages of the semantic release process. The packages used as
well as scripts to run at different stages are specified in the .releaserc.json file. In this case
we use standard semantic-release and add a custom deploy script on top of the normal github release
setup. The custom deploy script is the new 'deploy.sh' file which takes the new version number as an
argument to deploy the package to PyPi and build the documentation.
#125