Fix #3463: Respect "Hide icons" preference in chevron menu #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
… is enabled Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Plaese fix https://github.com/eclipse-platform/eclipse.platform.ui/issues/3463
Fix #3463: Respect "Hide icons" preference in chevron menu
Nov 3, 2025
Copilot finished work on behalf of
laeubi
November 3, 2025 12:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chevron menu (view stack overflow popup) was showing icons even when the "Hide icons" preference was enabled, creating visual inconsistency with the tabs themselves which correctly hide icons.
Changes
Modified
BasicPartList.javato check theHIDE_ICONS_FOR_VIEW_TABSpreference:shouldHideIcons()method that checks the preference usingPlatform.getPreferencesService(), matching the pattern inCTabRenderingPartStackUtil.isEditorStack()since the preference only applies to view stacksBasicStackListLabelProvider.getImage()to returnnullwhen icons should be hiddenThe chevron menu now respects the preference setting consistently with tab rendering behavior.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.