Fix invalid usage of OGRE_DIR in CMakeLists.txt #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspindle
reviewed
Jul 10, 2023
| list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}/cmake") | ||
| list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}/CMake") | ||
| list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}") | ||
| list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}") |
There was a problem hiding this comment.
Hi, thanks for this PR.
I would prefer that you add a new path instead of replacing that could lead to side effects.
Your 2 lines are the same.
Since windows is unable to make difference between lower and upper case, put simply
list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}/cmake")
list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}")
There was a problem hiding this comment.
My bad, did not paid attention that it lead to duplicated lines.
Ok to me to keep both OGRE_DIR paths (with and without the cmake suffix).
| list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}/cmake") | ||
| list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}/CMake") | ||
| list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}") | ||
| list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}") | ||
| list(APPEND CMAKE_MODULE_PATH "/usr/local/lib/OGRE/cmake") |
There was a problem hiding this comment.
and here:
list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}/cmake")
list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}/CMake")
list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}")
There was a problem hiding this comment.
should be list(APPEND CMAKE_MODULE_PATH "${OGRE_DIR}/CMake")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OGRE_DIRcmake variable seems not correctly used here, as it will be set to the directory containing the configuration cmake file (as defined here: https://cmake.org/cmake/help/latest/command/find_package.html#full-signature ).In other words, the
OGRE_DIRvariable typically already ends up with a/cmakedirectory, so theCMAKE_MODULE_PATHshould not be appended by an extra/cmakedirectory.