Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canny auto threshold #1213

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Canny auto threshold #1213

merged 4 commits into from
Aug 30, 2023

Conversation

rolalaro
Copy link

@rolalaro rolalaro commented Aug 9, 2023

Added several features:

  • a vpImageFilter::median that computes the median of a single- or multi- channel image
  • the possibility to ask the automatic computation of the Canny edge detector thresholds
  • update of the tutorial accordingly
  • update of the tests to test the vpImageFilter::median methods

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 67.07% and project coverage change: -0.01% ⚠️

Comparison is base (83555f3) 54.98% compared to head (fcf0a43) 54.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1213      +/-   ##
==========================================
- Coverage   54.98%   54.97%   -0.01%     
==========================================
  Files         399      399              
  Lines       49201    49252      +51     
==========================================
+ Hits        27051    27075      +24     
- Misses      22150    22177      +27     
Files Changed Coverage Δ
modules/core/src/image/vpImageFilter.cpp 60.54% <53.44%> (-3.29%) ⬇️
modules/core/include/visp3/core/vpImageFilter.h 92.34% <100.00%> (-0.05%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rlagneau and others added 2 commits August 17, 2023 12:04
- code indentation
- doxygen doc improvements
- alphabetical order in vpImageFilter.h
@fspindle
Copy link
Contributor

Ready to merge when ci ok

@fspindle fspindle merged commit 1ac0aae into lagadic:master Aug 30, 2023
57 of 58 checks passed
@rolalaro rolalaro deleted the cannyAutoThreshold branch October 5, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants