Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mid-optimization normal filtering to MBT #1463

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

SamFlt
Copy link
Contributor

@SamFlt SamFlt commented Sep 13, 2024

This PR adds face rejection mid optimization for the MBT for the normal tracker. This is necessary, as filtering faces before VVS is not stringent enough: some faces that are close to being rejected before optimization have a strong adverse effect on VVS, leading to divergence. This is due to the fact that as the plane gets closer to being parallel to the camera axis and D gets to 0, the interaction matrix blows up.

This can observed in the Blender MBT tutorial, where turning on normals led to divergence before the fix.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.26%. Comparing base (b6350f6) to head (9db7431).
Report is 164 commits behind head on master.

Files with missing lines Patch % Lines
...s/tracker/mbt/src/depth/vpMbDepthNormalTracker.cpp 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1463      +/-   ##
==========================================
- Coverage   45.42%   45.26%   -0.16%     
==========================================
  Files        1110     1121      +11     
  Lines      110525   112151    +1626     
  Branches    18923    19078     +155     
==========================================
+ Hits        50203    50766     +563     
- Misses      60322    61385    +1063     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle
Copy link
Contributor

@SamFlt thanks

@fspindle fspindle merged commit b2d0ca3 into lagadic:master Sep 16, 2024
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants