Add mid-optimization normal filtering to MBT #1463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds face rejection mid optimization for the MBT for the normal tracker. This is necessary, as filtering faces before VVS is not stringent enough: some faces that are close to being rejected before optimization have a strong adverse effect on VVS, leading to divergence. This is due to the fact that as the plane gets closer to being parallel to the camera axis and D gets to 0, the interaction matrix blows up.
This can observed in the Blender MBT tutorial, where turning on normals led to divergence before the fix.