File chooser (XFCE-style) #94
Conversation
lah7
added
patch new
There was a problem hiding this comment.
Thanks for contributing. As-is, I can't accept the patch as it affects users outside of XFCE. The patch is in the series file - the PKGBUILD doesn't matter as this only concerns checksums.
I suppose one compromise could have been to offer this as an optional patch by commenting it out in the series file, but I don't think many users would do this at build time - users would have to handle this every time (multiple reasons this would end up messy). Plus, this is difficult for Ubuntu as their package is built for a PPA repository. In either case, introducing optional patches makes maintenance difficult, so this (and branches) are out of the question.
This might work if the new patch is reworked to make the changes optional behind a environment variable flag (e.g. GTK_XFCE_FILE_CHOOSER=1) ... or only if XDG_SESSION_DESKTOP == XFCE.
That said, did XFCE ever look like this under GTK 2, or is it purely a personal visual improvement? I'm still unsure about accepting such patch, as it's desktop-specific and these "classic" patches should remain agnostic.
|
That's fair. I don't recall GTK ever looking [as nice!] as this. This is mostly just for me (making my desktop look consistent). I can see it'd be inconvenient to package additional branches, however, for me it's incredibly convenient to pull down from a separate repository and add it on top of this one. So I'll close this PR and create a new personal repository (likely named 'gtk3-classic-xfce'), which can then be superset on top of this one. i.e. Apply patches from here for the classic GTK look, and then for a more XFCE-leaning look apply the patch(es) of my personal repository. As an aside, I appreciate you starting/continuing this crusade. I was just about to start patching GTK myself when I stumbled upon this repository. I am proficient in C (although do despise the way in which it's used in GTK), so I'll take a browse through the open issues and see if I can't help. |
ghost
closed this
ghost
deleted the
|
Glad to hear! I take no credit for majority of the patches. The repository passed hands a few times, so I stepped up to keep them rolling along the latest GTK 3 and act as a community hub. Probably the biggest downfall is CSD being broken in newer versions of some apps (#32) - and maybe XFCE (#92). I think separating XFCE-specific improvements is a good idea. I've added a note in the README. They're just a https://github.com/simplejack-src/gtk3-classic-xfce |
This patch was originally proposed in #94. The diff is still there. Looks like the GitHub account has been deleted for at least 5 months and just spotted the link rot. Fortunately, there is still an AUR package to apply XFCE specific patches on top of ours.
This change modifies the the File Chooser Dialog to look more in line with Thunar (Pixel-perfect with the theme I'm using).
Note: I've intentionally left this change off the PKGBUILD as its an appearance change that might look strange outside of an XFCE environment.
EDIT: Perhaps this could go on an XFCE specific branch?