Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding URL issue - android app #5

Closed
RiqueAM opened this issue Oct 17, 2022 · 11 comments
Closed

encoding URL issue - android app #5

RiqueAM opened this issue Oct 17, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@RiqueAM
Copy link

RiqueAM commented Oct 17, 2022

First of all, I thank you deeply for bringing this tool that helps a lot of people's daily tasks! May you be blessed for that!

For URL decoding it works great, but for encoding it doesn't work properly.

Example of how it should work:
Input:
H+4sIAGLWTWMA/7NRdPF3DokMQMAKykNUQ8AAAA=

Output:
H%2B4sIAGLWTWMA%2F7NRdPF3DokMQMAKykNUQ8AAAA%3D%0A

As is:
Output:
H+4sIAGLWTWMA/7NRdPF3DokMQMAKykNUQ8AAAA=

The characters "+/=" are not converting at all. From what I could tell, the app is actually only converting spaces and line breaks. I haven't tested the other characters, but I think it's all broken.

Here's a good site to test URL encode and decode:
https://www.urlencoder.org

@laiiihz laiiihz self-assigned this Oct 18, 2022
@laiiihz
Copy link
Owner

laiiihz commented Oct 18, 2022

i'll look into this 🙌
now only support encode/decode full uri ,next version will add a option for encode/decode uri component and uri query component.

@RiqueAM RiqueAM changed the title encoding url issue - android app encoding URL issue - android app Oct 18, 2022
@RiqueAM
Copy link
Author

RiqueAM commented Oct 18, 2022

i'll look into this 🙌 now only support encode/decode full uri ,next version will add a option for encode/decode uri component and uri query component.

I don't understand what you mean, I just use it and I've always needed to use URL encode and decode and I've never seen it this way. I'll try to compile with the fix as default in a fork.

@laiiihz
Copy link
Owner

laiiihz commented Oct 18, 2022

sorry for not explained clearly,
for example:
the default encode/decode uri will not encode/decode those characters A-Z a-z 0-9 ; , / ? : @ & = + $ - _ . ! ~ * ' ( ) # ,detail.
and in your situation, i'll provider a option which called encode uri component, that encoder/decoder will encode/decode all characters excepts A-Z a-z 0-9 - _ . ! ~ * ' ( ).
input:

H+4sIAGLWTWMA/7NRdPF3DokMQMAKykNUQ8AAAA=

output:

H%2B4sIAGLWTWMA%2F7NRdPF3DokMQMAKykNUQ8AAAA%3D

and last welcome make PRs 🥳

@RiqueAM
Copy link
Author

RiqueAM commented Oct 18, 2022

forgive me I'm very noob in all this anyway, I think I'll wait for your new version, now I'm excited

@laiiihz laiiihz added the enhancement New feature or request label Oct 18, 2022
@laiiihz
Copy link
Owner

laiiihz commented Oct 18, 2022

next version will have this feature. by the way thanks a lot ! @RiqueAM

@RiqueAM
Copy link
Author

RiqueAM commented Oct 18, 2022

let me help at least to locate in pt-BR ? where are the string language files?

@laiiihz
Copy link
Owner

laiiihz commented Oct 18, 2022

https://github.com/laiiihz/alga/blob/main/lib/l10n/app_en.arb
@RiqueAM

@laiiihz
Copy link
Owner

laiiihz commented Oct 18, 2022

copy this file and rename to app_pt_BR.arb maybe

@laiiihz
Copy link
Owner

laiiihz commented Oct 18, 2022

this feature has been added. close this issue.
if have any question you can reopen this.😆
and i make a new issue #6 about other languages.

@laiiihz laiiihz closed this as completed Oct 18, 2022
@Ahplla
Copy link

Ahplla commented Oct 19, 2022

@RiqueAM u did?

@laiiihz
Copy link
Owner

laiiihz commented Oct 19, 2022

@RiqueAM u did?

i have fix the uri encode/decode issue, and im still working on #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants