-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3.11: add the __getstate__
dunder
#73
Conversation
This patch adds enough support for the testcases to pass on Python 3.11.
5fb9c3d
to
9b349c2
Compare
9b349c2
to
1f46115
Compare
I don't entirely understand why pdm is being super specific here, it seems to be saying that it can't select numpy (which has a |
I think the error happens because numpy 1.12.6 (which is the currently pinned version) is incompatible with the new restriction Numpy is only needed as a dep of Pandas (which is required by tests), so you should be able to run |
Seems to be a bit more interesting than that, running this fails to resolve with the following:
Which sets numpy to >= 1.21.0 when the Python version is >= 3.10. However, numpy does not support 3.11 yet in any release so it's not resolvable. Perhaps this PR needs to wait until numpy has support? :) |
Honestly suspicious as 1.23.5 wheels have been released yesterday for numpy, which do have 3.11 support. Let's wait a few days :) |
SG. I think we need a new release of pandas that supports 3.11, as numpy is not a direct dependency actually, seems it's already supported pandas-dev/pandas#46680 |
@laike9m the package already has |
@aqeelat I think new versions have been released so I'll package those and see if tests fail and do any followup PR as necessary :) |
Yes, the new release supports |
This patch adds enough support for the testcases to pass on Python 3.11.
I (currently) maintain the Fedora package for pdir2 and wrote this patch when we couldn't build this package in F37. I should've upstreamed it earlier :)
This adds in the
__getstate__
method that was breaking the testcases on Python 3.11.