Add FilesystemPath string conversion operator
#1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This time mark it as `explicit`.
The `<filesystem>` api expects `std::filesystem::path` objects. These can be implicitly constructed from `std::string`. They can not be implicitly constructed by something that implicitly converts to `std::string`. Hence we always need to be explicit with these calls.
This makes it much easier to build error messages that display a path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For debugging purposes it's convenient have to have
FilesystemPatheasily convert to astd::string.It also helps to have concatenation operations with string literals.
This conversion operator existed previously, though was not marked as
explicit.I was tempted to remove the
string()method when this was added. One reason to keep it is thestd::filesystem::pathclass has astring()method, so it makes the two types more compatible. For a program usingauto, it may be possible to switch between them for simple cases.Related:
RealPathto mount #1285FilesystemPathclass #1279FilesystemPathclass #1284