Add method FilesystemPath::isRelative()
#1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's tempting to add an
isAbsolute()method as well, though the positive form of the test case presents challenges with Windows. The path/is considered relative on Windows (relative to the drive of the current working directory), while it is absolute on Linux and MacOS. Meanwhile a path such asC:\won't have the same meaning on Linux and MacOS, where it would be considered a relative filename.The same could be said for the negative form of an
isRelativetest. That's one reason why there are no negative tests for this member function.Related:
RealPathto mount #1285