Add FilesystemPathParents
#1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
FilesystemPathParentscollection class, which allows for easy iteration over parent folders, with an optional maximum number of levels.This is maybe a little overkill to put into NAS2D. Not sure if we really want to provide this as a library feature, or treat it as an internal implementation detail that could be simplified or removed in the future. Potentially just the code from the
parentCountfunction could have been used to implement the path searching feature for #1285. Though having the full abstraction means something custom could be easily written if the issue feature isn't a perfect match. It might also be nice to have this as part of history if nothing more than to document how to do this sort of thing.Related:
RealPathto mount #1285