To ad method #6
Open
To ad method #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check BS date validity
…week-for-bs-to-ad Get beginning/end of month/week for bs to ad
…what the original author had done. Oringal repo: https://github.com/lalusaud/nepali_calendar/
Danphe/debug conversion issue
* fiscal year feature * test for fiscal year feature * removed unwanted files * stubs Date to pass test for all date * removes new lines * - merged with fiscal-year-features * fix for fetching wrong last date of the given fiscal year and implementation of FiscalYear class * removed unnessary file and minor changes in fiscal_year * changes form review * cleanup * minor fixes * FiscalYear object and refactoring * changes from review * updates rails version to 6 * rails version to 6.1.0 * changes in fiscal year methods * few adjustments in specs * re written test case for FiscalYear * more test cases for FIscalYear * BsCalendar object instead of Calendar only Co-authored-by: sagar535 <070bct535@ioe.edu.np>
* fiscal year feature * test for fiscal year feature * removed unwanted files * stubs Date to pass test for all date * removes new lines * - merged with fiscal-year-features * fix for fetching wrong last date of the given fiscal year and implementation of FiscalYear class * removed unnessary file and minor changes in fiscal_year * changes form review * cleanup * minor fixes * FiscalYear object and refactoring * changes from review * updates rails version to 6 * rails version to 6.1.0 * changes in fiscal year methods * few adjustments in specs * re written test case for FiscalYear * more test cases for FIscalYear * BsCalendar object instead of Calendar only * readme usage update * Usage update and headers * usage changes * possible fixes from rubocop -a and few manual ones * updated readme * Reindent lines and code formatting in Readme.md changed to ruby * fixes from rubocop * fixes Co-authored-by: sagar535 <070bct535@ioe.edu.np>
Minor styling fixes.
* fiscal year feature * test for fiscal year feature * removed unwanted files * stubs Date to pass test for all date * removes new lines * - merged with fiscal-year-features * fix for fetching wrong last date of the given fiscal year and implementation of FiscalYear class * removed unnessary file and minor changes in fiscal_year * changes form review * cleanup * minor fixes * FiscalYear object and refactoring * changes from review * updates rails version to 6 * rails version to 6.1.0 * changes in fiscal year methods * few adjustments in specs * re written test case for FiscalYear * more test cases for FIscalYear * BsCalendar object instead of Calendar only * readme usage update * Usage update and headers * usage changes * possible fixes from rubocop -a and few manual ones * updated readme * Reindent lines and code formatting in Readme.md changed to ruby * fixes from rubocop * fixes * readme updaet Co-authored-by: sagar535 <070bct535@ioe.edu.np>
…eek day name and minor fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.