Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes (typo, abbreviations) + fix incomplete citations #25

Merged
merged 11 commits into from
Aug 19, 2024

Conversation

marawilhelmi
Copy link
Contributor

@marawilhelmi marawilhelmi commented Aug 8, 2024

(See notion for all the requested changes that I addressed here)

Summary by Sourcery

Fix typos, abbreviations, and incomplete citations in BibTeX entries. Adjust x-axis range and ticks in the confidence vs. performance plot. Correct a typo in the benchmark corpus figure description and fix incorrect model performance comparison in the appendix.

Bug Fixes:

  • Corrected author names and formatting in multiple BibTeX entries.
  • Fixed incomplete citations by adding missing fields such as 'eprint' and 'url'.
  • Adjusted x-axis range and ticks in the confidence vs. performance plot to correct display issues.
  • Corrected a typo in the description of the benchmark corpus figure.
  • Fixed incorrect model performance comparison in the appendix.

Enhancements:

  • Standardized abbreviations and expanded acronyms in the main text and BibTeX entries for clarity.

Copy link

sourcery-ai bot commented Aug 8, 2024

Reviewer's Guide by Sourcery

This pull request addresses several small fixes including typos, abbreviations, and incomplete citations. The changes include formatting corrections in the bibliography, adjustments to plot settings in analysis scripts, and minor text corrections in the main document and appendix.

File-Level Changes

Files Changes
src/tex/references.bib
src/tex/ms.tex
src/tex/appendix.tex
Corrected typos, abbreviations, and citation completeness in bibliography and main text files.
src/scripts/joint_analysis_confidence_performance.py
src/scripts/analyze_performance_per_source.py
Adjusted plot settings and expanded abbreviations in analysis scripts.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marawilhelmi - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

src/tex/references.bib Outdated Show resolved Hide resolved
src/tex/references.bib Outdated Show resolved Hide resolved
src/tex/references.bib Outdated Show resolved Hide resolved
AdrianM0 and others added 3 commits August 19, 2024 10:58
Co-authored-by: Martiño Rios-Garcia <147555961+MrtinoRG@users.noreply.github.com>
Co-authored-by: Martiño Rios-Garcia <147555961+MrtinoRG@users.noreply.github.com>
Co-authored-by: Martiño Rios-Garcia <147555961+MrtinoRG@users.noreply.github.com>
src/tex/ms.tex Outdated Show resolved Hide resolved
@AdrianM0
Copy link
Contributor

AdrianM0 commented Aug 19, 2024

Thanks for the changes @marawilhelmi! I will try fixing the actions, and then merge (edit: will do it later)

@AdrianM0 AdrianM0 merged commit 7f5787a into main Aug 19, 2024
0 of 2 checks passed
@AdrianM0 AdrianM0 deleted the Mara_0808 branch August 19, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants