Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add React text #86

Merged
merged 22 commits into from
Oct 29, 2024
Merged

feat: add React text #86

merged 22 commits into from
Oct 29, 2024

Conversation

MrtinoRG
Copy link
Contributor

@MrtinoRG MrtinoRG commented Oct 29, 2024

Summary by Sourcery

Enhance the appendix with detailed information on tool-augmented models, specifically ReAct-style environments, and their performance. Update the documentation to include explanations of the tools used and their impact on model performance.

Enhancements:

  • Enhance the appendix to include detailed information on tool-augmented models, specifically ReAct-style environments, and their performance.

Documentation:

  • Update the appendix to provide a comprehensive explanation of tool-augmented models and their performance, including the use of specific tools like WolframAlpha and ArXiv API.

Copy link
Contributor

sourcery-ai bot commented Oct 29, 2024

Reviewer's Guide by Sourcery

The changes primarily focus on expanding the documentation in the LaTeX files by adding a new subsection about tool-augmented models and updating existing content. The implementation includes adding references, modifying captions, and linking new content with existing sections.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a new subsection discussing tool-augmented models and their performance
  • Introduced discussion of ReAct-style tool augmentation environment
  • Described available tools including WolframAlpha, ArXiv API, Wikipedia, and web search
  • Explained performance comparisons between models with and without tools
  • Discussed implementation challenges and engineering requirements
src/tex/appendix.tex
Updated table caption with additional context about model configurations
  • Added explanation of T-one temperature setting
  • Included information about ReAct systems and their constraints
  • Added cross-reference to new ReAct environment section
src/tex/appendix.tex
Enhanced conclusion section with reference to ReAct systems
  • Added reference to ReAct systems discussion
  • Included cross-reference to new section
src/tex/ms.tex
Added new bibliography entry
  • Added citation for Chain-of-Thought prompting paper
src/tex/references.bib

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MrtinoRG - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider standardizing the capitalization of 'LLM'/'llm' throughout the document for consistency
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

src/tex/appendix.tex Outdated Show resolved Hide resolved
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
src/tex/appendix.tex Outdated Show resolved Hide resolved
src/tex/appendix.tex Outdated Show resolved Hide resolved
src/tex/appendix.tex Outdated Show resolved Hide resolved
src/tex/appendix.tex Outdated Show resolved Hide resolved
src/tex/appendix.tex Outdated Show resolved Hide resolved
src/tex/appendix.tex Outdated Show resolved Hide resolved
src/tex/appendix.tex Outdated Show resolved Hide resolved
MrtinoRG and others added 7 commits October 29, 2024 15:41
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
src/tex/appendix.tex Outdated Show resolved Hide resolved
src/tex/appendix.tex Outdated Show resolved Hide resolved
src/tex/appendix.tex Outdated Show resolved Hide resolved
src/tex/appendix.tex Outdated Show resolved Hide resolved
src/tex/appendix.tex Outdated Show resolved Hide resolved
src/tex/appendix.tex Outdated Show resolved Hide resolved
MrtinoRG and others added 7 commits October 29, 2024 16:00
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
src/tex/ms.tex Outdated Show resolved Hide resolved
Copy link
Contributor

@kjappelbaum kjappelbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
src/tex/appendix.tex Outdated Show resolved Hide resolved
src/tex/ms.tex Outdated Show resolved Hide resolved
MrtinoRG and others added 2 commits October 29, 2024 16:34
Co-authored-by: Adrian Mirza <adrianmirza81@gmail.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
@kjappelbaum
Copy link
Contributor

If we could add a citation to langchain at a good place we are done here, I think!

@software{Chase_LangChain_2022,
author = {Chase, Harrison},
month = oct,
title = {{LangChain}},
url = {https://github.com/langchain-ai/langchain},
year = {2022}
}

@MrtinoRG
Copy link
Contributor Author

Done!

@@ -291,6 +291,14 @@ @Article{caufield2023structured
year = {2024},
}

@software{Chase_LangChain_2022,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to later check how this renders, but it is good for now. Thanks!

Copy link
Contributor

@kjappelbaum kjappelbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wohoo! 🚀

@kjappelbaum kjappelbaum merged commit fbf0ffe into main Oct 29, 2024
0 of 2 checks passed
@kjappelbaum kjappelbaum changed the title React text feat: add React text Oct 29, 2024
@kjappelbaum kjappelbaum deleted the react_text branch October 29, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants