Update memory handling and pointer size calculations for JNA #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- src/jvmCommonMain/kotlin/com/github/lamba92/leveldb/jvm/JvmLevelDB.kt: Language not supported
- src/jvmCommonMain/kotlin/com/github/lamba92/leveldb/jvm/JvmUtills.kt: Language not supported
lamba92
force-pushed
the
native-memory-again
branch
2 times, most recently
from
2a4785a to
050b4da
Compare
Replaced string-based memory allocation with UTF-8 encoded byte arrays for better compatibility and precision. Adjusted key and value length calculations to use the size of pointers instead of string lengths, ensuring correctness when working with native libraries. These changes improve robustness and prevent potential errors in memory operations.
lamba92
force-pushed
the
native-memory-again
branch
from
050b4da to
349dd0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced string-based memory allocation with UTF-8 encoded byte arrays for better compatibility and precision. Adjusted key and value length calculations to use the size of pointers instead of string lengths, ensuring correctness when working with native libraries. These changes improve robustness and prevent potential errors in memory operations.