Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map downloader bugged #569

Closed
jaer3221 opened this issue Jul 20, 2023 · 0 comments · Fixed by #573
Closed

Map downloader bugged #569

jaer3221 opened this issue Jul 20, 2023 · 0 comments · Fixed by #573
Labels
bug Something isn't working

Comments

@jaer3221
Copy link

Describe the bug
Map downloader module doesn't download maps with special characters in map name

Steps to reproduce the bug

  1. Have map name with any special character (, |, /, :,*, ?, ", <, > ) in your inventory
  2. Activate MapDownloader module
  3. Map is not present in /lambda/map-images folder
  4. Minecraft console logs java.io.FileNotFoundException

Expected behavior
Map should apear in the folder named with no special character in its name

Debug info
the ;tsc command doesn't work after the bug occurs (probably something u guys have to look into also) but here it is the same command right before the bug is replicated:
image

Additional context / media
The bug is actually pretty easy to fix. Just add ".replace("char", "_")" in "src/main/kotlin/com/lambda/client/module/modules/misc/MapDownloader.kt", where char is a special character (, |, /, :,*, ?, ", <, > ).
This could be done better just by turning the string into an ASCII or just using a good regular expression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant