Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla elytra flight rewrite and AutoOffhand changes #540

Merged
merged 10 commits into from
Aug 8, 2023

Conversation

nickcat325
Copy link
Contributor

@nickcat325 nickcat325 commented May 22, 2023

Describe the pull

Elytra flight:
This pull request adds Speed Threshold when the player is faster then the speed threshold, it uses the Up Pitch value. Slow Percentage rotates the pitch into the Down Pitch value. Low percents rotate fast, high percents rotate slow. This pull also adds description of the settings and comments for the code.

AutoOffhand:
Fixed the toggles, added a Offhand Totem toggle, added a Conditional setting.

Added Align Coords to Coordinates

Describe how this pull is helpful

Elytra flight:
This pull request adds more dynamic speed controls that allows elytra flight in vanilla mode to gain height. These new controls should be easy to use.

AutoOffhand:
Disabling the conditional setting makes AutoOffhand easier to use and can be enabled for more control.

Additional context

The old conditional code is difficult to read. I can't guarantee it all works properly. However, this shouldn't matter to most people because it's disabled by default.

@nickcat325 nickcat325 changed the title Speed Threshold for Vanilla Elytra Flight mode e-fly that gains height May 23, 2023
@nickcat325 nickcat325 marked this pull request as ready for review May 23, 2023 11:17
@nickcat325 nickcat325 changed the title e-fly that gains height (Do not merge) efly that gains height May 27, 2023
@nickcat325 nickcat325 changed the title (Do not merge) efly that gains height Vanilla elytra flight rewrite May 29, 2023
@nickcat325 nickcat325 changed the title Vanilla elytra flight rewrite Vanilla elytra flight rewrite and AutoOffhand changes May 30, 2023
@Avanatiker Avanatiker self-requested a review June 5, 2023 00:41
@Avanatiker
Copy link
Member

Thanks a lot sorry for the long wait

@Avanatiker Avanatiker merged commit 821a71f into lambda-client:master Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants